Skip to content

Commit ff51c6f

Browse files
authored
Fix: Ios Release Build (#172)
* fix: iOS release build — remove stale CocoaPods, fix workspace and versioning - Use -workspace instead of -project in mobile:ios:release so SPM dependencies resolve - Remove stale CocoaPods references from pbxproj (project uses SPM) - Fix placeholder team ID in ExportOptions.plist - Add mobile:ios:set-version script to sync iOS version from package.json * chore: changelog
1 parent df22bb4 commit ff51c6f

4 files changed

Lines changed: 6 additions & 15 deletions

File tree

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44

55
### Features
66

7+
* [FIX][mobile] Fixed iOS release build by removing stale CocoaPods references, using correct workspace target, fixing ExportOptions team ID, and adding auto-versioning from `package.json`. (#172)
78
* [FEATURE][mobile] **Embedded dApp browser** for iOS and Android with multi-instance tabs, parked-dApp switcher tray, and native navbar overlay.
89
* [FEATURE][all] Migrated backend from `WasmWebClient` to the new `MidenClient` TypeScript API. All service-worker WASM access now goes through `MidenClientInterface` wrapping the high-level `MidenClient` surface.
910
* [FEATURE][all] Migrated frontend to `@miden-sdk/react` hooks (`useMiden`, `useSyncState`, `useAccount`, etc.), replacing manual sync and balance-polling logic.

ios/App/App.xcodeproj/project.pbxproj

Lines changed: 2 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@
3434
50B271D01FEDC1A000F3C39B /* public */ = {isa = PBXFileReference; lastKnownFileType = folder; path = public; sourceTree = "<group>"; };
3535
873F0344C8952CB5585102E0 /* App.entitlements */ = {isa = PBXFileReference; includeInIndex = 1; lastKnownFileType = text.plist.entitlements; path = App.entitlements; sourceTree = "<group>"; };
3636
958DCC722DB07C7200EA8C5F /* debug.xcconfig */ = {isa = PBXFileReference; lastKnownFileType = text.xcconfig; name = debug.xcconfig; path = ../debug.xcconfig; sourceTree = SOURCE_ROOT; };
37-
BFB20C26958B0AB36D108D0E /* Pods-App.release.xcconfig */ = {isa = PBXFileReference; includeInIndex = 1; lastKnownFileType = text.xcconfig; name = "Pods-App.release.xcconfig"; path = "Target Support Files/Pods-App/Pods-App.release.xcconfig"; sourceTree = "<group>"; };
3837
C7D4E92B3F8B1C5D00A2B9E2 /* BarcodeScannerPlugin.swift */ = {isa = PBXFileReference; includeInIndex = 1; lastKnownFileType = sourcecode.swift; path = BarcodeScannerPlugin.swift; sourceTree = "<group>"; };
3938
/* End PBXFileReference section */
4039

@@ -56,7 +55,6 @@
5655
958DCC722DB07C7200EA8C5F /* debug.xcconfig */,
5756
504EC3061FED79650016851F /* App */,
5857
504EC3051FED79650016851F /* Products */,
59-
7B7BBBA72F32232100E56E23 /* Recovered References */,
6058
);
6159
sourceTree = "<group>";
6260
};
@@ -87,14 +85,6 @@
8785
path = App;
8886
sourceTree = "<group>";
8987
};
90-
7B7BBBA72F32232100E56E23 /* Recovered References */ = {
91-
isa = PBXGroup;
92-
children = (
93-
BFB20C26958B0AB36D108D0E /* Pods-App.release.xcconfig */,
94-
);
95-
name = "Recovered References";
96-
sourceTree = "<group>";
97-
};
9888
/* End PBXGroup section */
9989

10090
/* Begin PBXNativeTarget section */
@@ -321,7 +311,7 @@
321311
ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
322312
CODE_SIGN_ENTITLEMENTS = App/App.entitlements;
323313
CODE_SIGN_STYLE = Automatic;
324-
CURRENT_PROJECT_VERSION = 2;
314+
CURRENT_PROJECT_VERSION = 3;
325315
DEVELOPMENT_TEAM = YQ9XQQJ5ZM;
326316
INFOPLIST_FILE = App/Info.plist;
327317
IPHONEOS_DEPLOYMENT_TARGET = 15.0;
@@ -341,12 +331,11 @@
341331
};
342332
504EC3181FED79650016851F /* Release */ = {
343333
isa = XCBuildConfiguration;
344-
baseConfigurationReference = BFB20C26958B0AB36D108D0E /* Pods-App.release.xcconfig */;
345334
buildSettings = {
346335
ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
347336
CODE_SIGN_ENTITLEMENTS = App/App.entitlements;
348337
CODE_SIGN_STYLE = Automatic;
349-
CURRENT_PROJECT_VERSION = 2;
338+
CURRENT_PROJECT_VERSION = 3;
350339
DEVELOPMENT_TEAM = YQ9XQQJ5ZM;
351340
INFOPLIST_FILE = App/Info.plist;
352341
IPHONEOS_DEPLOYMENT_TARGET = 15.0;

ios/App/ExportOptions.plist

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
<key>signingStyle</key>
1010
<string>automatic</string>
1111
<key>teamID</key>
12-
<string>YOUR_TEAM_ID</string>
12+
<string>YQ9XQQJ5ZM</string>
1313
<key>uploadSymbols</key>
1414
<true/>
1515
<key>manageAppVersionAndBuildNumber</key>

package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,8 @@
3131
"mobile:android:release": "yarn mobile:sync && cd android && ./gradlew bundleRelease && echo 'AAB created at: android/app/build/outputs/bundle/release/app-release.aab'",
3232
"mobile:android:release:apk": "yarn mobile:sync && cd android && ./gradlew assembleRelease && echo 'APK created at: android/app/build/outputs/apk/release/app-release.apk'",
3333
"mobile:android:keystore": "keytool -genkey -v -keystore android/app/miden-release.keystore -alias miden -keyalg RSA -keysize 2048 -validity 10000",
34-
"mobile:ios:release": "yarn mobile:sync && xcodebuild -project ios/App/App.xcodeproj -scheme App -configuration Release -archivePath ios/App/build/MidenWallet.xcarchive archive && echo 'Archive created at: ios/App/build/MidenWallet.xcarchive'",
34+
"mobile:ios:set-version": "cd ios/App && xcrun agvtool new-marketing-version $(node -p \"require('../../package.json').version\") && xcrun agvtool next-version -all",
35+
"mobile:ios:release": "yarn mobile:sync && yarn mobile:ios:set-version && xcodebuild -workspace ios/App/App.xcworkspace -scheme App -configuration Release -archivePath ios/App/build/MidenWallet.xcarchive archive && echo 'Archive created at: ios/App/build/MidenWallet.xcarchive'",
3536
"mobile:ios:export": "xcodebuild -exportArchive -archivePath ios/App/build/MidenWallet.xcarchive -exportPath ios/App/build/export -exportOptionsPlist ios/App/ExportOptions.plist",
3637
"zip": "ts-node --project ./tsconfig-utility.json ./utility/buildZip.ts",
3738
"test": "jest",

0 commit comments

Comments
 (0)