Skip to content

NTX builder may be loading duplicate IDs #1868

@igamigo

Description

@igamigo

While reviewing #1843, I saw that the ntx-builder startup preload path may not be using GetNetworkAccountIds fully correctly.

GetNetworkAccountIds returns PaginationInfo, and the store side treats pagination_info.block_num as the last fully included block in the page, as documented in the query function and returned by the store server. However, the ntx-builder client resumes from that same block in store instead of block_num + 1, while the underlying DB query uses an inclusive lower bound, which means the page requests overlap.

I am not sure this is a bug at all, but currently it seems that the pagination semantics are not being followed and the response could contain overlapping data. cc @SantiagoPittella to confirm

Metadata

Metadata

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions