Skip to content

Remove local Plonky3 workarounds where upstream now supports them #952

@adr1anh

Description

@adr1anh

We maintain several extension traits and copied code to work around missing upstream Plonky3 features. Some of these have since been merged upstream and can be replaced.

Ready to remove

Still needs upstream work

  • RowMajorMatrixBitrevPackedExt (prover/constraints/packed_row_bitrev.rs) — Extension trait for accessing vertically packed rows from bit-reversed storage. No upstream equivalent.
  • horner_acc/horner (pcs/utils.rs) — Generic Horner fold helpers. Could be proposed upstream.

Local cleanup

  • log2_strict_u8 — Duplicated in lifted-air/src/util.rs and lmcs/utils.rs. Deduplicate.

Ported from 0xMiden/p3-miden#25

Metadata

Metadata

Assignees

No one assigned

    Labels

    starksRelated to Plonky3 migration

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions