Replies: 2 comments 4 replies
-
|
Pinging @Al-Kindi-0 |
Beta Was this translation helpful? Give feedback.
0 replies
-
|
The cheap way to test this idea would be to make a |
Beta Was this translation helpful? Give feedback.
4 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
Why
As we discussed on our calls while I was working on #808 having two separate
Felttypes for the on-chain and off-chain code is quite painful:Word,Asset,AssetId, etc);Word);How
I wonder if using conditional compilation and a cargo feature would allow us to have one
Felttype in both on-chain and off-chain code.Something along these lines:
The
true-feltfeature is needed for the web-client that builds Rust code for thewasmtarget (right?). The web-client would be built with thetrue-feltfeature enabled to haveu64felt.Obviously we would have to do it in a separate, very slim crate (
miden-felt?) that would be at the bottom of our dependency chain withwinter-mathandmiden(SDK) depending on it. And another crate (miden-core-types?) with the core types likeWord,Asset,AssetId,Recipient, etc. that we want to share between the on-chain and the off-chain code that would be a dependency for miden-base andmiden(SDK).Pros:
Cons:
miden-feltandmiden-core-typescrates would require more effort to propagate everywhere;If you think this approach is worth pursuing I could whip up a PoC to test the idea.
@bitwalker @otrho @bobbinth Thoughts?
Beta Was this translation helpful? Give feedback.
All reactions