refactor: move celestia-app to testdata (#31)

julienrbrt · web-flow · commit a695ae179cd7 · 2025-03-07T10:01:04.000+01:00
* refactor: move celestia-app to testdata

* updates

* fixes
diff --git a/appd/internal/testdata/celestia-app_Darwin_arm64.tar.gz b/appd/internal/testdata/celestia-app_Darwin_arm64.tar.gz
diff --git a/appd/internal/testdata/celestia-app_Darwin_x86_64.tar.gz b/appd/internal/testdata/celestia-app_Darwin_x86_64.tar.gz
diff --git a/appd/internal/testdata/celestia-app_Linux_arm64.tar.gz b/appd/internal/testdata/celestia-app_Linux_arm64.tar.gz
diff --git a/appd/internal/testdata/celestia-app_Linux_x86_64.tar.gz b/appd/internal/testdata/celestia-app_Linux_x86_64.tar.gz
diff --git a/appd/internal/testdata/data.go b/appd/internal/testdata/data.go
@@ -1,4 +1,4 @@
-package appd
+package testdata
 
 import (
 	"fmt"
diff --git a/appd/internal/testdata/data_darwin_amd64.go b/appd/internal/testdata/data_darwin_amd64.go
@@ -1,4 +1,4 @@
-package appd
+package testdata
 
 import _ "embed"
 
diff --git a/appd/internal/testdata/data_darwin_arm64.go b/appd/internal/testdata/data_darwin_arm64.go
@@ -1,4 +1,4 @@
-package appd
+package testdata
 
 import _ "embed"
 
diff --git a/appd/internal/testdata/data_linux_amd64.go b/appd/internal/testdata/data_linux_amd64.go
@@ -1,4 +1,4 @@
-package appd
+package testdata
 
 import _ "embed"
 
diff --git a/appd/internal/testdata/data_linux_arm64.go b/appd/internal/testdata/data_linux_arm64.go
@@ -1,4 +1,4 @@
-package appd
+package testdata
 
 import _ "embed"
 
diff --git a/appd/internal/testdata/data_test.go b/appd/internal/testdata/data_test.go
@@ -1,9 +1,10 @@
-package appd
+package testdata
 
 import (
 	"fmt"
-	"github.com/stretchr/testify/require"
 	"testing"
+
+	"github.com/stretchr/testify/require"
 )
 
 func TestCelestiaApp(t *testing.T) {
diff --git a/appd/run.go b/appd/run.go
@@ -26,11 +26,7 @@ type Appd struct {
 // New takes a binary and untar it in a temporary directory.
 func New(name string, bin []byte, cfg ...CfgOption) (*Appd, error) {
 	if len(bin) == 0 {
-		var err error
-		bin, err = CelestiaApp()
-		if err != nil {
-			return nil, fmt.Errorf("fallback celestia-app failed; failed to get binary data for %s: %w", name, err)
-		}
+		return nil, fmt.Errorf("no binary data available: ensure `bin` is not empty")
 	}
 
 	// untar the binary.
diff --git a/appd/run_test.go b/appd/run_test.go
@@ -2,14 +2,19 @@ package appd
 
 import (
 	"bytes"
-	"github.com/stretchr/testify/require"
 	"os"
 	"testing"
+
+	"github.com/01builders/nova/appd/internal/testdata"
+	"github.com/stretchr/testify/require"
 )
 
 // TestCreateExecCommand execs a command to an embedded binary.
 func TestCreateExecCommand(t *testing.T) {
-	appdInstance, err := New("test-app", nil)
+	bin, err := testdata.CelestiaApp()
+	require.NoError(t, err)
+
+	appdInstance, err := New("test-app", bin)
 	require.NoError(t, err)
 	require.NotNil(t, appdInstance)
 

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-package appd`
	`1`	`+package testdata`
`2`	`2`
`3`	`3`	`import (`
`4`	`4`	`"fmt"`