From 31129c99605dd23b56e9ec00d59c32656d7fb18b Mon Sep 17 00:00:00 2001 From: a0a0mf4 Date: Tue, 8 Jul 2025 10:31:03 +0530 Subject: [PATCH] added implementation of assertInstanceOf for junit 4. Signed-off-by: a0a0mf4 --- .../ConnectionConfigSocketTimeoutTest.java | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/java-client/src/test/java/org/opensearch/client/transport/httpclient5/ConnectionConfigSocketTimeoutTest.java b/java-client/src/test/java/org/opensearch/client/transport/httpclient5/ConnectionConfigSocketTimeoutTest.java index 63ce07a97f..abf07efde8 100644 --- a/java-client/src/test/java/org/opensearch/client/transport/httpclient5/ConnectionConfigSocketTimeoutTest.java +++ b/java-client/src/test/java/org/opensearch/client/transport/httpclient5/ConnectionConfigSocketTimeoutTest.java @@ -27,6 +27,7 @@ import org.apache.hc.core5.http.HttpHost; import org.apache.hc.core5.util.Timeout; import org.junit.After; +import org.junit.Assert; import org.junit.Before; import org.junit.Test; import org.opensearch.client.opensearch.OpenSearchClient; @@ -139,7 +140,17 @@ public void testClientSocketTimeoutOnMidResponseHang() { } } - private void assertInstanceOf(Class socketTimeoutExceptionClass, Throwable cause, String s) {} + private void assertInstanceOf(Class socketTimeoutExceptionClass, Throwable actualException, String message) { + + if (actualException == null) { + Assert.fail(message + " - Expected exception of type " + socketTimeoutExceptionClass.getSimpleName() + ", but got null"); + } + + Assert.assertTrue( + message + " - Expected " + socketTimeoutExceptionClass.getSimpleName() + " but got " + actualException.getClass().getSimpleName(), + socketTimeoutExceptionClass.isInstance(actualException) + ); + } public static OpenSearchClient createClientWithCustomTimeout(int socketTimeoutMs, String hostName) {